Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu-avatar-item): use correct theme color #1116

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

KaiSoellch
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

GitHub Issue Number: #1100

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Feb 23, 2024
@danielleroux danielleroux added this to the 2.1.1 milestone Feb 23, 2024
@danielleroux danielleroux changed the title fixed menu-avatar-item color fix(core/menu-avatar-item): use correct theme color Feb 23, 2024
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is not a nav item we should use the base basde color instead IMO

@danielleroux danielleroux modified the milestones: 2.1.1, 2.2.0 Feb 26, 2024
….scss

Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
@nuke-ellington nuke-ellington merged commit a15c619 into siemens:main Feb 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants