Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component multi selection pill overflow #124

Closed
nuke-ellington opened this issue Nov 7, 2022 · 5 comments · Fixed by #224
Closed

Select component multi selection pill overflow #124

nuke-ellington opened this issue Nov 7, 2022 · 5 comments · Fixed by #224
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@nuke-ellington
Copy link
Collaborator

I'm submitting a...


[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

If too many pills are present in the input field some might geht cropped and not visible.

Either a line break in the input or something like x items selected?

What is the motivation / use case for changing the behavior?

@nuke-ellington nuke-ellington added type: bug Something isn't working component: core triage We discuss this topic in our internal weekly labels Nov 7, 2022
@danielleroux danielleroux added this to the 1.1.1 milestone Nov 15, 2022
@goncalosard
Copy link
Contributor

@danielleroux @nuke-ellington
Made the branch (fix/pills-overflow), it contains the fix for this issue as shown in the image below.

Also i think the placeholder "Select an option" should be removed when there is at least one pill selected.

image

@goncalosard goncalosard self-assigned this Nov 17, 2022
@danielleroux danielleroux modified the milestones: 1.1.1, 1.2.0 Nov 21, 2022
@danielleroux
Copy link
Collaborator

@silviowolf fyi

@danielleroux danielleroux removed the triage We discuss this topic in our internal weekly label Nov 21, 2022
@silviowolf
Copy link
Collaborator

@danielleroux, I would suggest to handle the placeholder text (and also the input text) as an tem in line with the input chip items? If its content is too long for the remaining space it would wrap too the next line.
Example with input text:
image

Possible?

@nuke-ellington
Copy link
Collaborator Author

@danielleroux, I would suggest to handle the placeholder text (and also the input text) as an tem in line with the input chip items? If its content is too long for the remaining space it would wrap too the next line. Example with input text: image

Possible?

We still would need a max height/number of lines then.

@danielleroux danielleroux modified the milestones: 1.2.0, 1.1.2 Nov 30, 2022
@danielleroux
Copy link
Collaborator

Should be same behavior as ix-category-filter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants