Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button group has additonal border #151

Closed
danielleroux opened this issue Nov 18, 2022 · 3 comments · Fixed by #170
Closed

button group has additonal border #151

danielleroux opened this issue Nov 18, 2022 · 3 comments · Fixed by #170
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@danielleroux
Copy link
Collaborator

I'm submitting a...


[x] Bug report
[ ] Feature request
[ ] Documentation issue or request

Current behavior

image

Expected behavior

No doubled border in button group

@danielleroux danielleroux added type: bug Something isn't working component: core labels Nov 18, 2022
@danielleroux
Copy link
Collaborator Author

/cc @silviowolf

@danielleroux danielleroux added this to the 1.2.0 milestone Nov 21, 2022
@goncalosard
Copy link
Contributor

goncalosard commented Nov 21, 2022

@danielleroux @silviowolf
Made a branch with a possible fix ( fix/button-borders ).

Now when in a group, every button doesnt have a right border exepect the last one. Also another fix is we can make the middle buttons have the right and left borders halfed, making a normal border when two buttons are together.

At the moment the result is the following:
image

@goncalosard goncalosard self-assigned this Nov 21, 2022
@danielleroux
Copy link
Collaborator Author

@goncalosard lgtm to disable right border. I don't see any edge cases where this fix is not working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants