Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): radio button indeterminate #213

Merged
merged 2 commits into from
Dec 5, 2022
Merged

fix(core): radio button indeterminate #213

merged 2 commits into from
Dec 5, 2022

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

Pull request type

Please check the type of change your PR introduces:

  • Bug fix

What is the current behavior?

image

What is the new behavior?

image

Does this introduce a breaking change?

  • No

Testing

Tested locally

@goncalosard goncalosard linked an issue Dec 2, 2022 that may be closed by this pull request
@goncalosard goncalosard added type: bug Something isn't working component: core labels Dec 2, 2022
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit dbc0124 into main Dec 5, 2022
@danielleroux danielleroux deleted the fix/radiobutton branch December 5, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radiobutton not visible until radiobutton is checked
2 participants