Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): activate additional compiler features #219

Merged
merged 4 commits into from
Dec 7, 2022
Merged

feat(core): activate additional compiler features #219

merged 4 commits into from
Dec 7, 2022

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Dec 6, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • add vite support
  • add slot fix regading components which are not shadowDOM ready

Does this introduce a breaking change?

  • Yes
  • No

Addition Information

  • Bump 1.2.0-beta.0 regarding external tests

@danielleroux danielleroux added type: enhancement New feature or request component: core pull request affects patch version The pull request affects only patch version labels Dec 6, 2022
@danielleroux danielleroux added this to the 1.2.0 milestone Dec 6, 2022
@danielleroux danielleroux changed the title Fix/core feat(core): active additional compiler features Dec 6, 2022
@danielleroux danielleroux changed the title feat(core): active additional compiler features feat(core): activate additional compiler features Dec 6, 2022
@danielleroux danielleroux merged commit 90363be into main Dec 7, 2022
@danielleroux danielleroux deleted the fix/core branch December 7, 2022 05:37
@danielleroux danielleroux mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version type: enhancement New feature or request
Projects
Siemens iX
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielleroux @nuke-ellington