Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular/dropdown): add trigger directive #223

Merged

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #154

What is the new behavior?

  • Add angular directive to get nativeElement of template variable

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added type: enhancement New feature or request component: angular pull request affects minor version The pull request affects only minor version labels Dec 6, 2022
@danielleroux danielleroux added this to the 1.2.0 milestone Dec 6, 2022
@danielleroux danielleroux linked an issue Dec 6, 2022 that may be closed by this pull request
@danielleroux danielleroux merged commit e698bc9 into main Dec 7, 2022
@danielleroux danielleroux deleted the 154-angular-dropdown-integration-not-a-optimal-solution branch December 7, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version type: enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

angular dropdown integration not a optimal solution
2 participants