Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core/theme): add new theme util #271

Merged
merged 7 commits into from Jan 12, 2023
Merged

refactor(core/theme): add new theme util #271

merged 7 commits into from Jan 12, 2023

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Dec 22, 2022 •
edited by danielleroux

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux could you maybe help with this PR?
Open points:

  • ThemeService import in angular-test-app broken
  • Playground gives site not found in docs
  • React theme utils missing

@nuke-ellington nuke-ellington linked an issue Dec 22, 2022 that may be closed by this pull request
Dark/light mode switcher #242
Closed
@danielleroux danielleroux self-requested a review January 11, 2023 05:55
@danielleroux danielleroux added this to the 1.3.0 milestone Jan 11, 2023
@danielleroux danielleroux added component: core pull request affects minor version The pull request affects only minor version labels Jan 11, 2023
@nuke-ellington nuke-ellington removed the request for review from danielleroux January 12, 2023 15:16
danielleroux
danielleroux approved these changes Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @nuke-ellington co-reviewed after my changes are made

@danielleroux danielleroux merged commit 1506b20 into main Jan 12, 2023
@danielleroux danielleroux deleted the 242-darklight-mode-switcher branch January 12, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees

@nuke-ellington nuke-ellington

Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Dark/light mode switcher
2 participants
@nuke-ellington @danielleroux