Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core/workflow-steps): single state #464

Merged
merged 17 commits into from
Apr 18, 2023
Merged

fix(core/workflow-steps): single state #464

merged 17 commits into from
Apr 18, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #422

What is the new behavior?

  • Added a single state with no line, when there is only one step.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard linked an issue Mar 23, 2023 that may be closed by this pull request
'ix-workflow-steps' : Left side line should be removed when there is only single step exists. #422
Closed
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Mar 24, 2023
@danielleroux danielleroux added this to the 1.5.0 milestone Mar 24, 2023
danielleroux
danielleroux previously approved these changes Mar 28, 2023
View reviewed changes
@danielleroux danielleroux self-requested a review March 28, 2023 11:20
@danielleroux danielleroux dismissed their stale review March 28, 2023 11:20

Fix git history

@goncalosard
Copy link
Contributor Author

goncalosard commented Mar 30, 2023 •
edited
Loading

@nuke-ellington Lastest commit has:
The changes that you asked.
Found a bug where clickable didn't work for steps added after inicialization, the fix for this bug is already done in this commit also.

nuke-ellington
nuke-ellington approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit f4cf8b0 into main Apr 18, 2023
@danielleroux danielleroux deleted the fix/ix-workflow-steps-left-line branch April 18, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

'ix-workflow-steps' : Left side line should be removed when there is only single step exists.
3 participants
@goncalosard @danielleroux @nuke-ellington