Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/select): updated style and multimode functionality #516

Merged
merged 5 commits into from
May 23, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #385

What is the new behavior?

  • Added inset shadow to inputs
  • Multiselect doesnt close when a option is selected
  • Updated arrow hover effect
  • editable select arrow it is now square instead of a rectangular

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard changed the title Fix/select updates fix(core/select): updated style and multimode functionality May 5, 2023
@danielleroux danielleroux linked an issue May 8, 2023 that may be closed by this pull request
packages/core/src/index.html Outdated Show resolved Hide resolved
packages/core/src/components/select/select.scss Outdated Show resolved Hide resolved
@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label May 12, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 12, 2023
@danielleroux danielleroux merged commit 8db6883 into main May 23, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/select-updates branch May 23, 2023 09:34
nuke-ellington pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve select
2 participants