Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): integrate @siemens/ix-icons web components #524

Merged
merged 5 commits into from
May 12, 2023
Merged

feat(core): integrate @siemens/ix-icons web components #524

merged 5 commits into from
May 12, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented May 11, 2023 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

To Do

  • Replace with none beta version of @siemens/ix-icons@1.1.0 Will be done before release of 1.6.0
  • Fix documentation styling

What is the new behavior?

  • Integrate the @siemens/ix-icons as web component

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label May 11, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 11, 2023
@danielleroux danielleroux mentioned this pull request May 11, 2023
Closed
@danielleroux danielleroux marked this pull request as ready for review May 12, 2023 10:52
nuke-ellington
nuke-ellington approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 7a545c2 into main May 12, 2023
7 checks passed
@danielleroux danielleroux deleted the refactor/ix-icon branch May 12, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielleroux @nuke-ellington