Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/menu-item): update title when slot changes #539

Merged
merged 10 commits into from
May 23, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #463

  • Title not updating when slot (menu-item name) is changed.

What is the new behavior?

  • Added MutationObserver to check when slot is changed
  • When slot is changed, it triggers to change title

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@goncalosard goncalosard added this to the 1.6.0 milestone May 19, 2023
@goncalosard goncalosard linked an issue May 19, 2023 that may be closed by this pull request
@danielleroux danielleroux merged commit a36e82a into main May 23, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/menu-item-title branch May 23, 2023 08:33
nuke-ellington pushed a commit that referenced this pull request May 24, 2023
Co-authored-by: Daniel Leroux <daniel.leroux@siemens.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Sidebar Hover translation Issue
2 participants