Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/cards): add card related components #542

Merged
merged 62 commits into from
May 30, 2023
Merged

feat(core/cards): add card related components #542

merged 62 commits into from
May 30, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Add Card
  • Add PushCard
  • Add ActionCard
  • Add CardList

Does this introduce a breaking change?

  • Yes
  • No

danielleroux and others added 30 commits March 21, 2023 14:03
@danielleroux
feat(core/cards): add cards
41faa30
@danielleroux
feat: rename list to accordion
51cc4c9
@danielleroux
fix: remove expand content handling
f163b66
@danielleroux
fix: replace div with button tag
2681d23
@danielleroux
feat: add variants
5903893
@danielleroux
Merge remote-tracking branch 'origin/main' into feat/cards
180e6f5
@danielleroux
fix: border behavior
c20286b
@danielleroux
chore: rename header to title
5561644
@danielleroux
feat: add notification cards
d830dd8
@danielleroux
fix: expand color
e978d27
@danielleroux
feat: add coloring to cards
abcf1ca
@danielleroux
Merge remote-tracking branch 'origin/main' into feat/cards
5727a4c
@danielleroux
feat: add card-list container component
e7112a8
@danielleroux
feat: add animation to card list
4235b65
@danielleroux
feat: overflow handling to card list
18bf489
@danielleroux
feat: add event listener
22f0c65
@danielleroux
fix: show card borders
a068f55
@danielleroux
fix: remove min width from card
180410c
@danielleroux
feat: add basic layouting
e23cecf
@danielleroux
fix: content sizing
0608774
@danielleroux
feat: suppress flag
7159532
@nuke-ellington
fix(core/card): update layout and animation
0d3fba3
@nuke-ellington
fix(core/css-grid): update row gaps
874882f
@nuke-ellington
docs(core/button): fix jsdocs typo
4ddb891
@nuke-ellington
refactor(core/card): move card variant to card component
d7967d5
@nuke-ellington
fix(core/fonts): add header large
928f10f
@nuke-ellington
feat(core/action-card): add component
93a0301
@danielleroux
chore: remove grid example
f4d8c29
@danielleroux
chore: rename to push card
4748132
@danielleroux
Merge remote-tracking branch 'origin/main' into feat/cards
e2ad480
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label May 22, 2023
@danielleroux danielleroux added this to the 1.6.0 milestone May 22, 2023
nuke-ellington
nuke-ellington requested changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits

packages/core/src/components/action-card/action-card.tsx Outdated Show resolved Hide resolved
packages/core/src/components/card-accordion/card-accordion.tsx Outdated Show resolved Hide resolved
packages/core/src/components/card-accordion/card-accordion.tsx Outdated Show resolved Hide resolved
packages/core/src/components/card-accordion/card-accordion.tsx Show resolved Hide resolved
packages/core/src/components/card-list/card-list.tsx Show resolved Hide resolved
packages/core/src/components/layout/css-grid/css-grid-item.tsx Outdated Show resolved Hide resolved
packages/core/src/components/layout/css-grid/css-grid.tsx Outdated Show resolved Hide resolved
packages/core/src/components/layout/css-grid/css-grid.tsx Show resolved Hide resolved
packages/core/src/components/push-card/push-card.tsx Outdated Show resolved Hide resolved
packages/core/src/tests/push-card/basic/index.html Outdated Show resolved Hide resolved
nuke-ellington
nuke-ellington approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuke-ellington nuke-ellington changed the title feat(core/cards): add card variation feat(core/cards): add card related components May 30, 2023
@nuke-ellington nuke-ellington merged commit 510b131 into main May 30, 2023
7 checks passed
@danielleroux danielleroux mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielleroux @nuke-ellington