Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/tile): enable shadow dom #549

Merged
merged 2 commits into from
Jun 6, 2023
Merged

feat(core/tile): enable shadow dom #549

merged 2 commits into from
Jun 6, 2023

Conversation

christopher-bergwein-siemens
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #511

What is the new behavior?

Enable shadow dom

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label May 26, 2023
@danielleroux danielleroux added this to the 1.7.0 milestone May 26, 2023
nuke-ellington
nuke-ellington approved these changes May 26, 2023
View reviewed changes
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 2f4d843 into main Jun 6, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/tile-shadow-dom branch June 6, 2023 07:30
@danielleroux danielleroux modified the milestones: 1.7.0, 2.0.0 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuke-ellington nuke-ellington nuke-ellington approved these changes

@danielleroux danielleroux Awaiting requested review from danielleroux

Assignees
No one assigned
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christopher-bergwein-siemens @nuke-ellington @danielleroux