Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/avatar): new avatar component #598

Merged
merged 7 commits into from
Jun 28, 2023
Merged

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

[IX-22]

What is the new behavior?

  • New component Avatar
  • Added VRT
  • Added Documentation page

Does this introduce a breaking change?

  • Yes
  • No

@danielleroux danielleroux changed the title Feat(core/avatar): new Avatar component feat(core/avatar): new Avatar component Jun 27, 2023
@danielleroux danielleroux changed the title feat(core/avatar): new Avatar component feat(core/avatar): new avatar component Jun 27, 2023
Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now replace the the avatar inside ix-menu-avatar with the standalone component

https://github.com/siemens/ix/blob/main/packages/core/src/components/menu-avatar/menu-avatar.tsx#L105-L109

@danielleroux danielleroux merged commit 6bcda4f into main Jun 28, 2023
7 checks passed
@danielleroux danielleroux deleted the feat/avatar-image branch June 28, 2023 15:39
@danielleroux danielleroux added the pull request affects minor version The pull request affects only minor version label Jun 28, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants