Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/dropdown-button): deprecate unused property active #599

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

nuke-ellington
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects patch version The pull request affects only patch version label Jun 27, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jun 27, 2023
@danielleroux danielleroux changed the title docs(core/dropdown-button): deprecate unused property active fix(core/dropdown-button): deprecate unused property active Jun 27, 2023
@danielleroux danielleroux merged commit 029fdf9 into main Jun 27, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/dropdown-button branch June 27, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects patch version The pull request affects only patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants