Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize bundle size #611

Merged
merged 26 commits into from
Sep 20, 2023
Merged

feat(core): optimize bundle size #611

merged 26 commits into from
Sep 20, 2023

Conversation

danielleroux
Copy link
Collaborator

@danielleroux danielleroux commented Jun 30, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Replace all icons inside the lib with import style (no webfont files need for core anymore)
  • Change import style of web components

When we have solved issue #138 we expect a further improvements regarding bundle size.

Testing

React starter project with basic-navigation, menu and a button

  • (Left) @siemens/ix, @siemens/ix-react and @siemens/ix-icons with latest released version (1.6.x) results in a dist output of 2.2MB
  • (Right) same setup and demo code (after the refactoring) results in a dist output of 756KB
image

Does this introduce a breaking change?

  • Yes
  • No

nuke-ellington
nuke-ellington previously approved these changes Sep 19, 2023
@danielleroux danielleroux merged commit 43abb1b into main Sep 20, 2023
7 checks passed
@danielleroux danielleroux deleted the optimize-ix-build branch September 20, 2023 05:52
@danielleroux danielleroux added this to the 2.0.0 milestone Sep 20, 2023
@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants