Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core/toggle-button|icon-toggle-button): add new components #623

Merged
merged 25 commits into from
Aug 4, 2023
Merged

feat(core/toggle-button|icon-toggle-button): add new components #623

merged 25 commits into from
Aug 4, 2023

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Jul 11, 2023 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

  • TODO: Loading icon sizes

@nuke-ellington nuke-ellington added type: enhancement New feature or request component: core pull request affects minor version The pull request affects only minor version labels Jul 11, 2023
@nuke-ellington nuke-ellington added this to the 2.0.0 milestone Jul 11, 2023
nuke-ellington and others added 18 commits July 25, 2023 11:27
@nuke-ellington
fix(core/icon-toggle-button): set icon size
19fc13e
@nuke-ellington
docs(core/toggle-button|icon-toggle-button): update docs
bb0891e
@nuke-ellington
fix(core/toggle-button|icon-toggle-button): remove type property
48301ce
@nuke-ellington
Merge branch 'main' into feat/toggle-buttons
7710c60
@nuke-ellington
fix(core/toggle-button|icon-toggle-button): update variant capitaliza…
0314b3f 
…tion
@danielleroux
refactor(core/button): extract to base button
906b942
@nuke-ellington
fix(core/toggle-button|icon-toggle-button): make secondary default
0d88891
@danielleroux
fix: button sizes
54c2288
@danielleroux
chore: cleanup
1cc8f80
@nuke-ellington
Merge branch 'main' into feat/toggle-buttons
e0bfa50
@nuke-ellington
fix(core/icon-toggle-button): resize spinner according to size
f153e56
@nuke-ellington
Merge branch 'fix/button-shadow-dom' into feat/toggle-buttons
22c8e93
@nuke-ellington
feat(core/button): add aria attributes to base button type
252d3f4
@nuke-ellington
refactor(core/pagination): prune index button and replace by base button
a1e4c9d
@nuke-ellington
Merge branch 'main' into feat/toggle-buttons
9ddab20
@nuke-ellington
test(core/icon-button): update vrt snapshots
4a42648
@nuke-ellington
refactor(core/icon-toggle-button): use base button
f5448a9
@nuke-ellington
refactor(core/icon-toggle-button): use icon button base
7fa32d2
@danielleroux danielleroux merged commit 8870e65 into main Aug 4, 2023
1 check passed
@danielleroux danielleroux deleted the feat/toggle-buttons branch August 4, 2023 10:14
danielleroux added a commit that referenced this pull request Aug 4, 2023
@danielleroux
Revert "feat(core/toggle-button|icon-toggle-button): add new componen…
61f02c2 
…ts (#623)"

This reverts commit 8870e65.
@danielleroux danielleroux mentioned this pull request Aug 4, 2023
Merged
@danielleroux danielleroux restored the feat/toggle-buttons branch August 4, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleroux danielleroux danielleroux approved these changes

Assignees
No one assigned
Labels
pull request affects minor version The pull request affects only minor version type: enhancement New feature or request
Projects
None yet
Milestone
2.0.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nuke-ellington @danielleroux