Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core/workflow-steps): onStepSelected event #626

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

goncalosard
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

[IX-314]

What is the new behavior?

  • Now onStepSelected works correctly emiting the index of the selected step.

Does this introduce a breaking change?

  • Yes
  • No

@goncalosard goncalosard added this to the 2.0.0 milestone Jul 11, 2023
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test case missing

Copy link
Collaborator

@danielleroux danielleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix not working:

        <ix-workflow-steps
          onStepSelected={(event) => {
            console.log(event.detail);
          }}
        >
          <ix-workflow-step>Step 0</ix-workflow-step>
          <ix-workflow-step>Step 1</ix-workflow-step>
          <ix-workflow-step>Step 2</ix-workflow-step>
        </ix-workflow-steps>

Should print the index of the step.

Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change - lgtm otherwise

BREAKING_CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas Maurer <lukas.maurer@siemens.com>
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit 4e8cac7 into main Aug 3, 2023
7 checks passed
@danielleroux danielleroux deleted the fix/workflow-steps-onstepselected branch August 3, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants