Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): change variant values to lower case #641

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

danielleroux
Copy link
Collaborator

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: Closing #622

What is the new behavior?

  • Button variants are all starting with an lower case
  • FlipTileState states all starting with an lower case

Does this introduce a breaking change?

  • Yes, see BREAKING_CHANGES.md
  • No

Testing

Other information

@danielleroux danielleroux added the pull request affects major version The pull request affects only major version label Jul 19, 2023
@danielleroux danielleroux added this to the 2.0.0 milestone Jul 19, 2023
BREAKING_CHANGES.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@nuke-ellington nuke-ellington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@danielleroux danielleroux merged commit c737d47 into main Jul 19, 2023
7 checks passed
@danielleroux danielleroux deleted the refactor-variant-values branch July 19, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects major version The pull request affects only major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants