Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/dropdown): allow trigger to toggle dropdown #872

Merged
merged 7 commits into from
Dec 8, 2023

Conversation

nuke-ellington
Copy link
Collaborator

@nuke-ellington nuke-ellington commented Oct 24, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • [] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Unit tests (yarn test) were run locally and passed
  • Visual Regression Tests (yarn visual-regression) were run locally and passed
  • Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bug fix
  • Feature
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: Closes #827

What is the new behavior?

  • Expose closeBehavior in dropdown button component
  • Close open dropdown on trigger click
  • Fix event handling if triggerEvent is array

Does this introduce a breaking change?

  • Yes
  • No

Testing

Other information

@nuke-ellington nuke-ellington added this to the 2.1.0 milestone Oct 24, 2023
@danielleroux danielleroux added pull request affects minor version The pull request affects only minor version and removed component: core labels Oct 24, 2023
@nuke-ellington nuke-ellington marked this pull request as draft October 25, 2023 14:18
@nuke-ellington nuke-ellington marked this pull request as ready for review November 13, 2023 10:51
@nuke-ellington nuke-ellington merged commit f33705a into main Dec 8, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull request affects minor version The pull request affects only minor version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown-button: closeBehavior
2 participants