Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply prettier to all directories #78

Closed
Metastasis opened this issue Oct 31, 2020 · 1 comment · Fixed by #85
Closed

Apply prettier to all directories #78

Metastasis opened this issue Oct 31, 2020 · 1 comment · Fixed by #85
Labels
accepted It is accepted to do important Do it first

Comments

@Metastasis
Copy link
Contributor

I would like to propose adding other folders (such as samples and test folders) to format script

Something like this

{
  "format:code": "prettier --write \"**/*.{js,ts}\""
}
@Siemienik
Copy link
Owner

Siemienik commented Nov 1, 2020

It is great idea, however we have to be sure do not format node_modules and dist.

I've also created issue #64, where i suggest replace prettier by eslint.

Further I am thinking about doing format automatically by GittHuba test (similar like for markdown)

@Siemienik Siemienik added accepted It is accepted to do important Do it first labels Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted It is accepted to do important Do it first
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants