Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab restore load problem ( replaced.js replaced.css ) #784

Closed
uberkael opened this issue May 24, 2021 · 5 comments
Closed

Tab restore load problem ( replaced.js replaced.css ) #784

uberkael opened this issue May 24, 2021 · 5 comments

Comments

@uberkael
Copy link

uberkael commented May 24, 2021

Short description

After restoring a session most of the tabs (but not all) show an intermediate page but does not load the original page.
Reloading the page does not help.
Reinstall the extension and restore the sessions does not fix the problem.
Also, an error is shown in the console.
image
ERR_FILE _NOT_FOUND
chrome-extension://iaiomicjabeggjcfkbimgmglanimpnae/replaced/replaced.css

Steps to reproduce

restore a normal session

Expected result

Restored tab load normally

Actual result

An intermediate page in most of the tabs showing "Copy URL" and the original URL.
image
Reload the page does not fix it, copying the link and load the URL does (obviously).

Platform information

  • Platform (OS): Windows 10
  • Version of browser: Chrome 91.0.4472.69
  • Version of Tab Session Manager: 6.8.1

Additional context

Looking at the code there is not replaced.css and line 2 of /src/replaced/replaced.js shows
import "./replaced.scss";
I think it was moved to replaced.scss on 908a08c

@Sife-ops
Copy link

Sife-ops commented May 27, 2021

Same exact problem on arch with vanilla chrome. One workaround is opening a new tab next to the restored tab and close it, but that is not really an acceptable fix.

@TUstudents
Copy link

TUstudents commented May 28, 2021

Exact same problem. Tabs are not restored, as the intermediate page has a problem to load "replaced.css". No way to rollback extension to a previous version in Chrome webstore, no way of adding a dummy css file to the extension folder as Chrome protection will disable it immediately.

CSS file is loaded in replaced.html at line 6 <link rel="stylesheet" type="text/css" href="replaced.css">

Platform information
Platform (OS): Windows 10
Version of browser: Brave Version 1.25.68 Chromium: 91.0.4472.77 (Official Build) (64-bit)
Version of Tab Session Manager: 6.8.1

Additional information
On another machine this bug is not present on Chrome Version 90.0.4430.212

@sienori sienori added the bug label May 30, 2021
@sienori
Copy link
Owner

sienori commented May 30, 2021

I fixed it. 03357e4
This was due to a specification change in Chrome 91. Thank you for the report!

@Sife-ops
Copy link

Awesome and thank you!!!

@uberkael
Copy link
Author

Great, Good Work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants