New array data-type #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having two classes for each array-dimension type we now have a single array which makes everything MUCH easier. Indeed the implementations are also much simpler to work with. To utilize the new method one may simply do: num = require "flos.num" and do a = num.Array( 2, 4 ) or a = num.Array( 2 ) Nearly all mathematical operations are present with the limitations of dot products of more than 2 dimension arrays. Signed-off-by: Nick Papior <nickpapior@gmail.com>
Now everything is using the new Array notation with much clearer intent and usage. I have checked: relax_geometry_* relax_cell.lua an everything seems to work seemlessly. I need to double check relax_cell_geometry, apparently it does not fully work as the initial one...? Signed-off-by: Nick Papior <nickpapior@gmail.com>
Signed-off-by: Nick Papior <nickpapior@gmail.com>
Signed-off-by: Nick Papior <nickpapior@gmail.com>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new data type for arrays is much more flexible in that any N-D array may be contained in a simple class.