-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid mjml silently fails #24
Comments
@jipiboily When I built this gem, |
It looks like a bunch of errors are still silent. If I dig into the code again or face silent errors I might tackle this. I don't have much free time right now, though. |
@jipiboily No problems, thanks for checking it out. I'll leave this issue open for the future. :-) |
@jipiboily solved by #27 |
If you input invalid mjml, mjml-rails doesn't raise any error and just siltenly fails.
Example:
This doesn't render and returns nothing (nil or empty string, not sure, didn't check).
It would be relatively easy to catch MJMLError or something like that and raise when we get that from the external rendering through the npm module.
Thoughts?
The text was updated successfully, but these errors were encountered: