Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render exception config #27

Merged
merged 4 commits into from Apr 3, 2018
Merged

Add render exception config #27

merged 4 commits into from Apr 3, 2018

Conversation

anhtrantuan
Copy link

Why is this necessary?

  • Current implementation of swallowing error in Mjml::Parse#render method is dangerous. Particularly, it does not only produce confusing result, but also make it difficult to debug.

What were changed?

  • Add exception raising configuration for Mjml::Parse#render method:
Mjml.setup do |config|
  # Default is `false` (errors suppressed), set to `true` to enable error raising
  config.raise_render_exception = true
end

@sighmon sighmon merged commit ef91cde into sighmon:master Apr 3, 2018
@sighmon
Copy link
Owner

sighmon commented Apr 3, 2018

Awesome, thanks @anhtrantuan. I'll push the new version to ruby gems soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants