Support e-drum

[leocaseiro]

This app is very cool, and it would be nice to also support e-drum. What are you thoughts on it?

[samouri]

What do you mean e-drum support? Playing the associated midi sounds or a new mode for learning to play e-drum songs? I think that would be great to add in

[leocaseiro]

I mean, as to connect a electronic drum via MIDI, and learn how to play songs, but instead of using a keyboard, to use a drumkit.

I was trying to work on that, and the sightread is almost ready for .mid that have drum tracks in a separated channel, but I wasn't able to see the tracks if the kid has all instruments in the same track.

[leocaseiro]

I mean, as to connect a electronic drum via MIDI, and learn how to play songs, but instead of using a keyboard, to use a drumkit.

I was trying to work on that, and the sightread is almost ready for .mid that have drum tracks in a separated channel, but I wasn't able to see the tracks if the kid has all instruments in the same track.

[leocaseiro]

I mean, as to connect a electronic drum via MIDI, and learn how to play songs, but instead of using a keyboard, to use a drumkit.

I was trying to work on that, and the sightread is almost ready for .mid that have drum tracks in a separated channel, but I wasn't able to see the tracks if the kid has all instruments in the same track.

[samouri]

@leocaseiro, let me know if you'd be willing to help add e-drum support! Do you have any examples of MIDI files you can send me?

[leocaseiro]

Hi @samouri, I would be very happy to contribute on it.

Sure, I attached 2 different types of MID.
SameTrackDrums.mid.zip

The first one, uses the same track, and that's the one I wasn't able to separate the drums.

The other track, I download a guitar pro file (gp5) from songsterr API (https://www.songsterr.com/a/ra/player/song/10586.plist?apiVersion=2), and converted into MIDI using GuitarPro.
That one is almost read to go on sightread. If you test this mid, you can see the track number 3 for the Drums.
(allthough, we would need to replace the drums soundfount).

But, if we just map the midis to the correct drum pad/cymbal, it would be ready to go to play with a e-drum. We can either also make minor changes to the UI to show as drums.

songsterr--michael-jackson-billie-jean.mid.zip

[samouri]

@leocaseiro, thank you for the contribution and example MIDIs. The first one is a format 0 MIDI which I never added support for, but would be great to do. I've been meaning to bolster the MIDI parsing and add unit tests for a long time, but haven't had the time. I should be able to get to it within the next month in case you'd prefer to focus on the drum visualization.

Do you have a discord username?

[leocaseiro]

Oh, I see. So the midi format is different? Awesome. I thought it was the tracks that were kind of different.
Good to know. (for what I quick researched, we just need to separate the tracks?)

I would prefer to work on midi mapping, and drum recognition.
My discord username is the same leocaseiro

[samouri]

@leocaseiro: parsing the different formats should work now. still need to teach the player to automatically infer percussion, but it works when manually mapped.

[leocaseiro]

I know I have been away for a while, but I am keen to try support e-drums still. I was able to auto infer the soundfont here #148

[leocaseiro]

Next step is to have a single staff for drums. Do you have a suggestion how to go with that?

Update: I found that we talked on discord about that an year ago hehe. Will look into that.

[samouri]

Good to hear from you @leocaseiro! I hope you've been well. I've also taken a break as life seems perennially busy.

I'll review your change in the next day or two 😀