Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: handle "-" and "." in vpn bucketNamePrefix #118

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix: handle "-" and "." in vpn bucketNamePrefix #118

merged 1 commit into from
Aug 8, 2023

Conversation

Al-Pragliola
Copy link
Member

@Al-Pragliola Al-Pragliola commented Jul 25, 2023 •
edited

Changelist:

  • added type AwsS3BucketNamePrefix to EKS schema
  • now spec.infrastructure.vpn.bucketNamePrefix uses AwsS3BucketNamePrefix

@Al-Pragliola Al-Pragliola self-assigned this Jul 25, 2023
@Al-Pragliola Al-Pragliola changed the title fix: added bucketnameprefix to schema Fix: handle "-" and "." in vpn bucketNamePrefix Jul 25, 2023
@Al-Pragliola Al-Pragliola marked this pull request as ready for review July 25, 2023 08:40
@Al-Pragliola Al-Pragliola added the bug Something isn't working label Jul 25, 2023
g-iannelli
g-iannelli approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@g-iannelli g-iannelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nutellinoit nutellinoit merged commit 72c1506 into main Aug 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-iannelli g-iannelli g-iannelli approved these changes

Assignees

@Al-Pragliola Al-Pragliola

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Al-Pragliola @g-iannelli @nutellinoit