Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure api server alternative names #80

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FedericoAntoniazzi
Copy link
Member

@FedericoAntoniazzi FedericoAntoniazzi commented Apr 26, 2024

Useful when accessing the cluster through a bastion.

In a context in which the API Server is accessible through a bastion, kubernetes_apiserver_certSANs can be used to set the IP address of the bastion as an alternative name in the API Server certificates.

The default value kubernetes_api_SAN has been removed since it wasn't used in the template for kubeadm.yaml file.

@FedericoAntoniazzi FedericoAntoniazzi changed the title Specify api server alternative names Configure api server alternative names Apr 26, 2024
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two very minor suggestions

roles/kube-control-plane/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube-control-plane/defaults/main.yml Outdated Show resolved Hide resolved
FedericoAntoniazzi and others added 2 commits May 23, 2024 09:51
Useful to set when accessing the cluster through a bastion

chore: apply suggestions from code review

Co-authored-by: Ramiro Algozino <ramiro@sighup.io>
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants