Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing AWS Regions to JSONSchema and Fix Region Validation Error #378

Merged
merged 1 commit into from
May 9, 2023

Conversation

smerlos
Copy link
Contributor

@smerlos smerlos commented May 9, 2023

Hi team,

This PR aims to address an issue where our JSONSchema was missing some AWS regions. I have updated the JSONSchema to include all AWS regions as listed in the official AWS documentation: https://docs.aws.amazon.com/general/latest/gr/rande.html

This should also resolve the validation error encountered when configuring spec.region. The error message was as follows:

ERRO error while validating configuration file: error while validating against schema: jsonschema: '/spec/region' does not validate with https://schema.sighup.io/kfd/ekscluster-kfd-v1alpha2-public.json#/properties/spec/$ref/properties/region/$ref/enum: value must be one of "af-south-1", "ap-east-1", "ap-northeast-1", "ap-northeast-2", "ap-northeast-3", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "ap-southeast-3", "ca-central-1", "eu-central-1", "eu-north-1", "eu-south-1", "eu-west-1", "eu-west-2", "eu-west-3", "me-central-1", "me-south-1", "sa-east-1", "us-east-1", "us-east-2", "us-west-1", "us-west-2"
DEBU Processing event: stop                       
DEBU Stop event received, stopping event processor 
DEBU Event processor stopped

By updating the JSONSchema to include all AWS regions, users should now be able to successfully configure spec.region without encountering this validation error.

Here is a brief changelog of this update:

Bug Fixes

  • jsonschema: add missing aws regions (86c281c)

Thank you for your attention to this matter, and please let me know if there are any questions or further issues.

@omissis omissis merged commit 493afb5 into develop May 9, 2023
@omissis omissis deleted the fix/ekscluster-kfd-schemas branch May 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants