Chart: change HPA api version to v2. Add chart tests #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralgozino
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Hi @michaelvl, thanks for the fix!
This PR also adds tests of the chart using GitHub actions and KIND. I realize this is a bit of a 'big' change for a small fix, but such tests may prove valuable for future additions. Testing is done using chart-testing https://github.com/helm/chart-testing and a few test values-files have been provided - one of which enables the HPA.
Thanks for the e2e test! We are using a different tool for CI and e2e testing. Would you mind removing that part from the PR to keep it scoped to the HPA fix?
I'll add some e2e tests for the chart based on your proposal.
Thanks again and have a nice day!
|
Sure. I have removed the CI parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
gatekeeper-policy-managerHelm chart use aHorizontalPodAutpscalerAPI version ofv2beta1, which was removed in Kubernetes 1.25. This PR updates the API version tov2. Thev2version became GA in Kubernetes 1.23.This PR also adds tests of the chart using GitHub actions and KIND. I realize this is a bit of a 'big' change for a small fix, but such tests may prove valuable for future additions. Testing is done using
chart-testinghttps://github.com/helm/chart-testing and a few test values-files have been provided - one of which enables the HPA.