Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-cert-and-token #109

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Conversation

billyen2012
Copy link
Contributor

Hey, this permission manager is extremely useful tool! It really made life easy.
However, it seems to have issue generate token and cert. (Not sure if anyone else also experienced the same but it will just got stuck after I clicked on the show kubeconfig button.)
I've made some changes that will fix the issue.

Also, I made a change to the workflow, so instead generate token from the service account, a Secret with type kubernetes.io/service-account-token will be created.
In this way, user can trace how many tokens have been issued and invalidate any token anytime they want to.

@luigibarbato luigibarbato linked an issue Jan 16, 2023 that may be closed by this pull request
@luigibarbato luigibarbato self-requested a review January 16, 2023 15:25
@luigibarbato luigibarbato added bug Something isn't working enhancement New feature or request labels Jan 16, 2023
@luigibarbato luigibarbato merged commit e5e8276 into sighupio:master Jan 16, 2023
@luigibarbato
Copy link
Contributor

@billyen2012 Thank you very much for your contribution, Awesome work! 💪🏾🚀

Copy link
Contributor

@luigibarbato luigibarbato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SBAM

@luigibarbato luigibarbato added this to the 1.8.0-rc1 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stuck on generating kubeconfig
2 participants