Move permission templates to values #97
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I did some changes to the helm-chart to have the possibility to push the chart to a registry.
If the chart is pushed to a registry, it should be possible to configure some permission templates in the values to deploy the templates with helm.
So I modified (and renamed) the "seed.yaml" to be able to configure the templates in the values file of the chart.
We have two options (that I have in mind):
Both ways are okay, but the current give the option to remove some templates if not needed or not allowed because of company security policies.
TODO:
Change the version based on the merges - it depends on which PR are merged first.
At all it is not a good idea to version the helm and the application together. I recommend to have different versions to helm and application.
I look forward to your review.
Thanks,
Jonah