Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move permission templates to values #97

Merged

Conversation

jonahbohlmann
Copy link
Contributor

@jonahbohlmann jonahbohlmann commented Jan 24, 2022

Hello,

I did some changes to the helm-chart to have the possibility to push the chart to a registry.

If the chart is pushed to a registry, it should be possible to configure some permission templates in the values to deploy the templates with helm.
So I modified (and renamed) the "seed.yaml" to be able to configure the templates in the values file of the chart.

We have two options (that I have in mind):

  • Keep it like I did
  • Add some default templates to seed.yaml and only allow to add new templates

Both ways are okay, but the current give the option to remove some templates if not needed or not allowed because of company security policies.

TODO:
Change the version based on the merges - it depends on which PR are merged first.
At all it is not a good idea to version the helm and the application together. I recommend to have different versions to helm and application.

I look forward to your review.

Thanks,
Jonah

@luigibarbato luigibarbato self-requested a review January 16, 2023 16:04
@luigibarbato luigibarbato added the enhancement New feature or request label Jan 16, 2023
@luigibarbato
Copy link
Contributor

Hi @jonahbohlmann 🙋🏽‍♂️ First of all, forgive me for the delay. We are back to active development of the Permission Manager. Anyway you did a great job, thanks for the contribution 💪🏾. Since it has been a while could you resolve the conflicts? Thank you :)

@jonahbohlmann
Copy link
Contributor Author

@luigibarbato love to see this project comes back. I merged the master to my branch. CI says, it is blocked, but I can't see the details. Can you check? Locally, it looks like it is working fine.

@luigibarbato
Copy link
Contributor

@luigibarbato love to see this project comes back. I merged the master to my branch. CI says, it is blocked, but I can't see the details. Can you check? Locally, it looks like it is working fine.

Thanks 🫂. Don't worry about that, in the next PRs the current CI will be redesigned.

Good Job ✌🏽

@luigibarbato luigibarbato merged commit 88bdb9d into sighupio:master Jan 17, 2023
@luigibarbato luigibarbato added this to the 1.8.0-rc1 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants