Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement oauth authentication (#10) #371

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Conversation

sigma67
Copy link
Owner

@sigma67 sigma67 commented Apr 4, 2023

Here it is. Please test! Looking forward to feedback.

Thanks to @vixalien for the TypeScript POC over at https://github.com/vixalien/muse.

@sigma67 sigma67 linked an issue Apr 4, 2023 that may be closed by this pull request
@sigma67 sigma67 self-assigned this Apr 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

Patch coverage: 96.06% and project coverage change: +0.70 🎉

Comparison is base (6aa6c8d) 95.17% compared to head (10e9477) 95.88%.

❗ Current head 10e9477 differs from pull request most recent head 08100dc. Consider uploading reports for the commit 08100dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   95.17%   95.88%   +0.70%     
==========================================
  Files          26       30       +4     
  Lines        1575     1992     +417     
==========================================
+ Hits         1499     1910     +411     
- Misses         76       82       +6     
Flag Coverage Δ
unittests 95.88% <96.06%> (+0.70%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ytmusicapi/auth/headers.py 91.30% <91.30%> (ø)
ytmusicapi/setup.py 91.66% <91.66%> (-0.65%) ⬇️
ytmusicapi/auth/browser.py 92.30% <92.30%> (ø)
ytmusicapi/auth/oauth.py 97.87% <97.87%> (ø)
tests/test.py 98.80% <100.00%> (ø)
ytmusicapi/__init__.py 81.81% <100.00%> (+4.04%) ⬆️
ytmusicapi/constants.py 100.00% <100.00%> (ø)
ytmusicapi/ytmusic.py 93.58% <100.00%> (+2.78%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sigma67 sigma67 merged commit 461783f into master Apr 5, 2023
@sigma67 sigma67 deleted the 10-proper-authentication branch January 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper authentication
2 participants