Only cache successful API responses #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldld
temporarily deployed
to
gosnowflake-ci-env
GitHub Actions
Inactive
duci9y
approved these changes
Mar 10, 2023
mtoader
approved these changes
Mar 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Caching failed responses prevents us from retrying on certain errors that can generally be retried. For example, if we get a "session expired" error, we would like to be able to retry after renewing the session (or creating a new session), rather than always serving a cached response.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them