[SIG-40455] fix arrow batch int64 to ntz/ltz #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yifeng-Sigma
temporarily deployed
to
gosnowflake-ci-env
GitHub Actions
Inactive
aldld
reviewed
Aug 5, 2023
converter.go
Outdated
| } else if col.DataType().ID() == arrow.INT64 { | ||
| for i, t := range col.(*array.Int64).Int64Values() { | ||
| if !col.IsNull(i) { | ||
| val := time.Unix(0, t*int64(math.Pow10(9-int(srcColumnMeta.Scale)))).UTC() |
There was a problem hiding this comment.
Other calls to time.Unix under case timestampLtzType aren't followed by .UTC(), is this deviation intentional?
There was a problem hiding this comment.
Good catch!
It's copy and paste mistake. I should follow line 1049.
Yifeng-Sigma
temporarily deployed
to
gosnowflake-ci-env
GitHub Actions
Inactive
aldld
approved these changes
Aug 5, 2023
aldld
reviewed
Aug 5, 2023
| @@ -941,6 +941,29 @@ func TestArrowToRecord(t *testing.T) { | |||
| return -1 | |||
| }, | |||
| }, | |||
| { | |||
| logical: "timestamp_ntz", | |||
There was a problem hiding this comment.
Can you also add a test for this case with timestmap_ltz?
There was a problem hiding this comment.
Missed this earlier. Follow up in #152
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://sigma-computing.sentry.io/issues/4369020647
panic: interface conversion: arrow.Array is *array.Int64, not *array.Timestampsometimes snowflake sends us int64 array and we want to interpret as timestamp.
underlying array.Timestamp is just int64.