Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIG-40738] convert binary array to string array #153

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

Yifeng-Sigma
Copy link

@Yifeng-Sigma Yifeng-Sigma commented Aug 10, 2023

We've seen sentry error on staging when arrow batch is enabled

https://sigma-computing.sentry.io/issues/4381126171/?alert_rule_id=10811375&alert_type=issue&project=6305692&referrer=slack

error is thrown here

                // ArrayType, VariantType, ObjectType, etc...
                (_, Variant, DataType::Utf8 | DataType::Binary) => {
                    let c = Column::Json(StringArray::from(a.data().clone()));
                    Ok((Variant, c))
                }

caused by

image

in QLC stack we only support string array. We have to convert non-UTF8 to string array.

@Yifeng-Sigma Yifeng-Sigma temporarily deployed to gosnowflake-ci-env August 10, 2023 03:12 — with GitHub Actions Inactive
@Yifeng-Sigma Yifeng-Sigma merged commit 5465ac7 into master Aug 10, 2023
3 of 4 checks passed
@Yifeng-Sigma Yifeng-Sigma deleted the yifeng/non-utf8 branch August 10, 2023 04:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants