Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIG-40820]don't panic if type mismatch is decode arrow #154

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

Yifeng-Sigma
Copy link

@Yifeng-Sigma Yifeng-Sigma commented Aug 11, 2023

Add a check to see type assertion fail or not.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@Yifeng-Sigma Yifeng-Sigma requested review from a team and mtoader August 11, 2023 21:21
@Yifeng-Sigma Yifeng-Sigma temporarily deployed to gosnowflake-ci-env August 11, 2023 21:38 — with GitHub Actions Inactive
@Yifeng-Sigma Yifeng-Sigma merged commit bc8b7b2 into master Aug 11, 2023
3 of 4 checks passed
@Yifeng-Sigma Yifeng-Sigma deleted the yifeng/no_panic branch August 11, 2023 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants