Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add repository attribute to Pull Destination object #614

Closed
sigmavirus24 opened this issue Jun 3, 2016 · 2 comments
Closed

Add repository attribute to Pull Destination object #614

sigmavirus24 opened this issue Jun 3, 2016 · 2 comments
Labels

Comments

@sigmavirus24
Copy link
Owner

sigmavirus24 commented Jun 3, 2016

Here we check to see if there's a 'repo' key in the decoded JSON. We should add self.repository = Repository(...) which uses that data.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34820541-add-repository-attribute-to-pull-destination-object?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F183477&utm_medium=issues&utm_source=github).
@ministrike3
Copy link
Contributor

ministrike3 commented Jul 16, 2016

Hey sigmavirus,
I'm trying to make my first ever Open Source commit. I understand that we're looking through the JSON that comes back for a 'repo' key, which I looked at on the single pull request github documentation.

screen shot 2016-07-15 at 5 48 00 pm

EDIT: I read the post title and understand im literally adding an attribute to the Pull Destination Attribute. I think I found it here, can you confirm that im in the right direction, or point me if not? https://github.com/sigmavirus24/github3.py/blob/develop/github3/repos/repo.py

EDIT2: If this is what im supposed to do, I think that im going to be creating a Repository object called self.repository, and the parentheses are for the various traits?

@ministrike3
Copy link
Contributor

self.repository = Repository(self.repository, self)
Would this be the correct line to add, probably at line 48?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants