Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch, resolve versioning #297

Closed
Teque5 opened this issue Sep 14, 2023 · 5 comments
Closed

Rename default branch, resolve versioning #297

Teque5 opened this issue Sep 14, 2023 · 5 comments
Assignees

Comments

@Teque5
Copy link
Collaborator

Teque5 commented Sep 14, 2023

Now that the spec has been separated from the python module, the versions are now separate too. There are a few outstanding issues in this repo that I'd like to resolve that were remnants from the before-times:

  • rename default branch from sigmf-v1.x to main
  • rename mis-named tags (SigMF-v1.0.0) to v1.0.0
  • create new release for v1.2.0. Most recent release is v1.0.0, but most recent tag is v1.1.0.
  • update the spec example version to match current release

If another maintainer signs off on these changes I can do this myself.

Do we want to move the logo to a separate repo?

@777arc
Copy link
Member

777arc commented Jan 12, 2024

I really like the idea of using "main" as the default branch name. I think logo is OK to stay in this repo, although an SVG of the logo would be pretty sweet if anyone can manage that =). I would suggest waiting for the json schema to get merged in before we cut a release, we can bump the version of the json schema along with the title in the markdown at the same time.

@Teque5
Copy link
Collaborator Author

Teque5 commented Jan 13, 2024

I think logo is OK to stay in this repo

It's a .sigmf file as an example where we can keep the metadata up to date w/the spec.

although an SVG of the logo would be pretty sweet if anyone can manage that =)

There are (7) svg versions of the logo in the zip file on this page. I think what you are suggesting is that we add logo-scope-color.svg to the repo, which may make sense since it's the most useful version. When I first added the png, I did that since GitHub wouldn't render an svg in a markdown file, but they added that feature in 2022. I'll make a PR.

@Teque5
Copy link
Collaborator Author

Teque5 commented Apr 6, 2024

As there are no objections I'm going to proceed:

  • Renaming the base branch to main and tags the appropriate commits for other versions.
  • Cleanup tags for all versions
  • Create a PR that updates the spec to 1.2.0.
  • Create a PR in sigmf-python for this branch -> now this PR
  • Create releases commensurate with tags
  • Create PyPi release for sigmf-python

@777arc
Copy link
Member

777arc commented Apr 6, 2024

Sounds good, I'll update my PR at some point

@Teque5
Copy link
Collaborator Author

Teque5 commented Apr 15, 2024

All tasks complete.

@Teque5 Teque5 closed this as completed Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants