Staging Updates to Python Code from Aerospace Corp. #119
Conversation
The following squashed commit was approved for public release by **The Aerospace Corporation** on 2019-05-07. It is covered software release request #SW19-0024. Commits made by the *Digital Communications Implementation Department*. New features - method to read & write SigMF metadata files - method to read available captures - method to read samples from captures - method to get annotations - method to count samples - python3 module compatibility - examples added to README Fixes - python3 relative path fixes - bug in test_validation - bug in conftest that used old SigMF datatype (f32) - additional test in test_sigmffile - made compatible with docker containers - can now write multiple annotations for same sample start index Pylint code cleanup - removed unused imports - fixed indentation - fixed snake_case and too short variables - fixed missing error definition Other changes - Remaining core namespace keys were added as constants to SigMFFile class. - Sample count is automatically determined and set as a class data member when a data file is present.
This squashed commit is approved for public release by The Aerospace Corporation on 2020-08-19. Commits made by the Communication Software Implementation Department. This commit is an addendum to the prior PR#106 approved 2019-05-07. New Features * Ordered sigmf-meta so that the keys are in a more useful order upon manual inspection. * Use cases in `README.md`. Fixes * Improved version handling.
…//github.com/Teque5/SigMF into Teque5-feature/aerospace-corp-python3-and-signal-io
…poration/SigMF into the-aerospace-corporation-release/public
…dit archive files.
|
Okay, I just cherry-picked @nathan-turner111's commit from #115 over to this branch. PR #115 and #116 shared a common history in changeset but not commits, so merging them both would have turned into a merge conflict nightmare. @nathan-turner111 @Teque5 - This PR should now include all 3 PRs that you've filed, and merging this branch will close all three. Focusing review / edits here to organize the effort. |
|
@Teque5, @nathan-turner111 - If you're able, it would be super helpful if you could pull this staged branch and test it to make sure it works as you expect as compared to your fork. Assuming it does, we should be good. If not, we just need to resolve the discrepancies. Tagging @dkozel, as well, as I know he has an interest in getting this done too. |
|
Just a ping on this, @Teque5! Any chance your team can give this branch a go? I believe it should be exactly what you are using in the branch on your fork. |
|
@bhilburn - I just pulled the branch and ran the GUI. It works as expected for me. However after some testing I realized I was not able to get the GUI running with python 3.6, so at least python 3.7 will be required to use it for now. I also noticed that the newest version of numpy requires python 3.5, but the project is classified under many versions of python below 3.5. I can't speak for @Teque5 commits. |
|
I will take a look at this in a few hours. |
|
So all the code from our PR looks fine and works with what we have. The GUI works just fine with python 3.6.9 on my Ubuntu 18.04 machine in a virtualenv. But I do have some notes:
|
This PR stages #106 and #116 onto
SigMF/master.I am staging these here because they are both rather large changesets, and the latter builds on the former, so I don't think it makes sense to evaluate #106 on its own at this point - especially since it was filed over a year ago.
@Teque5 - I confirmed that this staging branch correctly has your two changesets by
diffing it againstaerospace/public/release. The only difference is that you originally branched before I mergedCODE_OF_CONDUCT.mdintomaster(see 336fcec), and you haven't pulled since then.Update: have now also cherry-picked #115 to this branch.
Closes #106, #116, #115.