Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata Traceability Extension #288

Merged
merged 9 commits into from Sep 8, 2023

Conversation

Nepomuceno
Copy link
Contributor

@Nepomuceno Nepomuceno commented May 31, 2023

Issue: #287

View the rendered markdown here - https://github.com/Nepomuceno/SigMF/blob/traceability_extension/extensions/traceability.sigmf-ext.md

Introducing a metadata traceability extension to SigMF for maintaining an audit trail of modifications to the .sigmf-meta file. The "traceability" extension extends the existing "global" and "annotations" sections of SigMF. It allows users to include traceability information such as author details, timestamps of last modifications, revision numbers, and origin information related to where the original recording was stored.

I kindly request the SigMF community consider this proposal and evaluate the potential benefits it can bring to the ecosystem. Hopefully we can collaborate iteratively on this.

Thank you for your consideration.

closes #287

@777arc
Copy link
Member

777arc commented May 31, 2023

Could simplify it a bit by getting rid of the LastModified object and just having last_modified_author and last_modified_datetime in the root level

also shouldn't "revision" be a string so folks can do 0.0.1 and such? or is the plan to start at 0 and increment by 1

@Nepomuceno
Copy link
Contributor Author

Could simplify it a bit by getting rid of the LastModified object and just having last_modified_author and last_modified_datetime in the root level

also shouldn't "revision" be a string so folks can do 0.0.1 and such? or is the plan to start at 0 and increment by 1

I think we could rename the LastModified object to be a ChangeTrack object that way it can be used to things like last modified but also for things like created and other like that keeping this as one object makes easier to implement this and to validate especially if it is going to be used in multiple places.

I think the plan for the revision it is to be incremental and ordered so starting from 0 and any new change would add 1 to that index

@jacobagilbert
Copy link
Member

@Nepomuceno thanks for submitting this. This concept has actually come up before and I think there would be a lot of value in providing a canonical method of tracking this. I'm going to solicit a few other sources of input before I do a review.

@jacobagilbert
Copy link
Member

@Nepomuceno can you remove the item we flagged above, or advocate for its retention as an optional field so we can get this feature merged?

@777arc
Copy link
Member

777arc commented Sep 1, 2023

I chatted with him and we're going to remove it from this extension

@777arc 777arc self-requested a review September 1, 2023 23:26
@777arc 777arc changed the title Add Metadata Traceability Extension to SIGMF Add Metadata Traceability Extension to SigMF Sep 1, 2023
@777arc 777arc changed the title Add Metadata Traceability Extension to SigMF Metadata Traceability Extension Sep 1, 2023
@jacobagilbert jacobagilbert merged commit 75429f4 into sigmf:sigmf-v1.x Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Adding Metadata Traceability Extension to SigMF
3 participants