Improve NCD language #295
Merged
Improve NCD language #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobagilbert
force-pushed
the
ncd_language
branch
2 times, most recently
from
b0415c8
to
e2af752
Compare
and group NCD metadata fields together, being explicit about how they apply exclusively to NCDs.
jacobagilbert
force-pushed
the
ncd_language
branch
from
e2af752
to
dd857d1
Compare
jacobagilbert
added
the
clarification
Teque5
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More specific about what NCDs are and why they exist, the fact that all metadata is 'valid SigMF' and its just the dataset that isnt compliant.
Also groups NCD metadata fields together, being explicit about how they apply exclusively to NCDs, and provides some examples of when it would be appropriate to use the offset fields.
This does not change any end sigmf formatting or fields.