Clarify optional extensions #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It wasn't entirely clear to me what it means for an extension to be optional. I assume it means that the application must support the extension in order to parse the recording. This might be the case if the extension defines a new dataset format.
I've updated the definition of
optionalaccording to my understanding, and also updated the example below. I changed thespatialandantennaexamples to"optional": truesince I don't believe that these extensions define anything that applications should be required to parse.Finally, I noticed that the
antenna:haglandantenna:azimuth_anglefields in theantennaexample were broken, so I fixed them.