Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release cli v0.3.0 #1

Merged
merged 1 commit into from Aug 9, 2022
Merged

release cli v0.3.0 #1

merged 1 commit into from Aug 9, 2022

Conversation

scott-cotton
Copy link
Member

Change description

Manual PR because cli 'make release problem'

        • pushing                   formula=Formula/signadot-cli.rb repo=signadot/homebrew-tap
   ⨯ release failed after 324.93s error=homebrew tap formula: failed to publish artifacts: PUT https://api.github.com/repos/signadot/homebrew-tap/contents/Formula/signadot-cli.rb: 409 Could not update file: At least 1 approving re
view is required by reviewers with write access. []

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

url "https://github.com/signadot/cli/releases/download/v0.2.0/signadot-cli_darwin_amd64.tar.gz"
sha256 "721a628af4e0b9dc6f2e1a1aac0ba4845229058c662a086968ef1939d52f5550"

def install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this section is going away from the macos portion. Is that expected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the diff is just messy. The full file reads

# typed: false
# frozen_string_literal: true

# This file was generated by GoReleaser. DO NOT EDIT.
class SignadotCli < Formula
  desc "Command-line interface for Signadot"
  homepage "https://signadot.com"
  version "0.3.0"
  bottle :unneeded

  on_macos do
    if Hardware::CPU.intel?
      url "https://github.com/signadot/cli/releases/download/v0.3.0/signadot-cli_darwin_amd64.tar.gz"
      sha256 "7b5a349bf0829060bebf4076500cd8413e975810cdfb056bf346f0a709e91a59"
    end
    if Hardware::CPU.arm?
      url "https://github.com/signadot/cli/releases/download/v0.3.0/signadot-cli_darwin_arm64.tar.gz"
      sha256 "089c0fedbea1b40efc479452f8353c5f8f82accd1c736bc02c54ab2753c00f63"
    end
  end

  on_linux do
    if Hardware::CPU.intel?
      url "https://github.com/signadot/cli/releases/download/v0.3.0/signadot-cli_linux_amd64.tar.gz"
      sha256 "f3b7ce2ed227bfae981ffca92720f9df1db091936cc95b9b67db577d198a4413"
    end
    if Hardware::CPU.arm? && Hardware::CPU.is_64_bit?
      url "https://github.com/signadot/cli/releases/download/v0.3.0/signadot-cli_linux_arm64.tar.gz"
      sha256 "20332cd51ecdfec56593e985e8fef499a4c66454d6bf3e4d40a1efb0107a6f53"
    end
  end

  def install
    bin.install "signadot"
  end
end

which looks right to me (it was just the output from the cli goreleaser run).

Copy link
Member

@foxish foxish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scott-cotton scott-cotton merged commit 9dc1b81 into main Aug 9, 2022
@foxish foxish deleted the release-v0.3.0-cli branch August 9, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants