Update hid.c #189
Closed
Update hid.c #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some Devices must be opened in share_mode= FILE_SHARE_READ | FILE_SHARE_WRITE for read access. In My case it was a Contour Express JogDial.
|
This should be fixed in b5b2e17 . Let me know if it's not. |
erikolofsson
pushed a commit
to Malterlib/hidapi
that referenced
this pull request
Nov 25, 2020
Read callback may fire itself on its own even after its been requested to stop and exactly before the calling code waits for its completion in indefinite loop. Explicitly preventing re-fireing the submission loop, fixes the issue. Fixes: signal11#142. Signed-off-by: Ihor Dutchak <ihor.youw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Devices must be opened in share_mode= FILE_SHARE_READ | FILE_SHARE_WRITE for read access. In My case it was a Contour Express JogDial.