Linux/hidraw: Ensure udev has initialized device before hid_enumerate returns it #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns it In hid_enumerate(), skip any devices which have not yet been initialized by udev (which includes setting permissions on the device node). Previously, a race condition was possible where hid_enumerate() could return a device that hid_open() could not open, because udev had not set permissions on the device node yet. This resolves issue 217, "Occasional 'permission denied' when opening device" (signal11#217)
|
Looks good to me |
|
One drawback I found while compiling under Ubuntu 10.04: udev didn't add the |
|
Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hid_enumerate(), skip any devices which have not yet been initialized by udev (which includes setting permissions on the device node).
Previously, a race condition was possible where hid_enumerate() could return a device that hid_open() could not open, because udev had not set permissions on the device node yet.
This resolves issue 217, "Occasional 'permission denied' when opening device" (#217)