Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change linux Makefile to reference updated hid library #96

Closed
wants to merge 1 commit into from
Closed

Change linux Makefile to reference updated hid library #96

wants to merge 1 commit into from

Conversation

gusaaaaa
Copy link

Makefile-manual in hidapi/linux referenced hid.o in its current directory instead of hid.o in ../libusb/hid.o. The former object file comes from an older version of the hid api, which returns the wrong device path in some linux distributions.

I've changed the Makefile-manual file to make it similar to hidapi/testgui/Makefile-manual.

@signal11
Copy link
Owner

Have you looked at this commit? It removes linux/hid.c and then you tell me that the Makefile is broken because it references the "old" hid.c file :)

@signal11 signal11 closed this Jan 17, 2013
@gusaaaaa
Copy link
Author

Sorry, I don't understand your point. The commit removes linux/hid.c because it is old, and changes Makefile-manual to reference the new one, in usblib/hid.c. The old hid.c returns the wrong device path in Ubuntu 12.04.1 LTS.

@signal11
Copy link
Owner

What makes you think that hid.c is old?
You should read the relevant section in README.txt about the 4 implementations of HIDAPI.

What device path does it return in libusb vs hidraw (linux/hid.c) in ubuntu 12.04? What makes you think the hidraw one is incorrect? Can you open the path given to you by hid_enumerate() with hid_open_path() using the hidraw implementation?

@gusaaaaa
Copy link
Author

You were right. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants