Add content descriptions for in-call buttons.

Fixes #9774
signalapp · Feb 9, 2022 · 210bb23 · 210bb23
1 parent de3a6a8
commit 210bb23
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/app/src/main/res/layout/webrtc_call_view.xml b/app/src/main/res/layout/webrtc_call_view.xml
@@ -217,6 +217,7 @@
             android:layout_marginBottom="8dp"
             android:scaleType="fitXY"
             android:visibility="gone"
+            android:contentDescription="@string/WebRtcCallView__speaker"
             app:layout_constraintBottom_toTopOf="@id/call_screen_button_labels_barrier"
             app:layout_constraintEnd_toStartOf="@id/call_screen_camera_direction_toggle"
             app:layout_constraintHorizontal_chainStyle="packed"
@@ -256,6 +257,7 @@
             android:clickable="false"
             android:scaleType="fitXY"
             android:visibility="gone"
+            android:contentDescription="@string/WebRtcCallView__flip"
             app:layout_constraintBottom_toTopOf="@id/call_screen_button_labels_barrier"
             app:layout_constraintEnd_toStartOf="@id/call_screen_video_toggle"
             app:layout_constraintHorizontal_chainStyle="packed"
@@ -293,6 +295,7 @@
             android:background="@drawable/webrtc_call_screen_video_toggle"
             android:stateListAnimator="@null"
             android:visibility="gone"
+            android:contentDescription="@string/WebRtcCallView__camera"
             app:layout_constraintBottom_toTopOf="@id/call_screen_button_labels_barrier"
             app:layout_constraintEnd_toStartOf="@id/call_screen_audio_mic_toggle"
             app:layout_constraintHorizontal_chainStyle="packed"
@@ -330,6 +333,7 @@
             android:background="@drawable/webrtc_call_screen_mic_toggle"
             android:stateListAnimator="@null"
             android:visibility="gone"
+            android:contentDescription="@string/WebRtcCallView__unmute"
             app:layout_constraintBottom_toTopOf="@id/call_screen_button_labels_barrier"
             app:layout_constraintEnd_toStartOf="@id/call_screen_audio_ring_toggle"
             app:layout_constraintHorizontal_chainStyle="packed"
@@ -401,6 +405,7 @@
             android:clickable="false"
             android:scaleType="fitXY"
             android:visibility="gone"
+            android:contentDescription="@string/WebRtcCallView__end_call"
             app:layout_constraintBottom_toTopOf="@id/call_screen_button_labels_barrier"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintHorizontal_chainStyle="packed"

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -1508,6 +1508,7 @@
     <string name="WebRtcCallView__flip">Flip</string>
     <string name="WebRtcCallView__speaker">Speaker</string>
     <string name="WebRtcCallView__camera">Camera</string>
+    <string name="WebRtcCallView__unmute">Unmute</string>
     <string name="WebRtcCallView__mute">Mute</string>
     <string name="WebRtcCallView__ring">Ring</string>
     <string name="WebRtcCallView__end_call">End call</string>