Skip to content

Commit

Permalink
directory changes to use number instead of token, group ui progress
Browse files Browse the repository at this point in the history
  • Loading branch information
mcginty committed Feb 12, 2014
1 parent 0af473d commit 9cd5a67
Show file tree
Hide file tree
Showing 21 changed files with 583 additions and 318 deletions.
102 changes: 57 additions & 45 deletions library/src/org/whispersystems/textsecure/directory/Directory.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,39 +7,41 @@
import android.database.sqlite.SQLiteOpenHelper;
import android.net.Uri;
import android.provider.ContactsContract.CommonDataKinds.Phone;
import android.telephony.TelephonyManager;
import android.util.Log;

import org.whispersystems.textsecure.push.ContactTokenDetails;
import org.whispersystems.textsecure.util.Base64;
import org.whispersystems.textsecure.push.ContactNumberDetails;
import org.whispersystems.textsecure.util.DirectoryUtil;
import org.whispersystems.textsecure.util.InvalidNumberException;
import org.whispersystems.textsecure.util.PhoneNumberFormatter;
import org.whispersystems.textsecure.util.Util;

import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;

public class Directory {

private static final int INTRODUCED_CHANGE_FROM_TOKEN_TO_E164_NUMBER = 2;
private static final int DATABASE_VERSION = 2;

private static final String DATABASE_NAME = "whisper_directory.db";
private static final int DATABASE_VERSION = 1;

private static final String TABLE_NAME = "directory";
private static final String ID = "_id";
private static final String TOKEN = "token";
private static final String NUMBER = "number";
private static final String REGISTERED = "registered";
private static final String RELAY = "relay";
private static final String SUPPORTS_SMS = "supports_sms";
private static final String TIMESTAMP = "timestamp";
private static final String CREATE_TABLE = "CREATE TABLE " + TABLE_NAME + "(" + ID + " INTEGER PRIMARY KEY, " +
TOKEN + " TEXT UNIQUE, " +
REGISTERED + " INTEGER, " +
RELAY + " TEXT, " +
SUPPORTS_SMS + " INTEGER, " +
TIMESTAMP + " INTEGER);";
NUMBER + " TEXT UNIQUE, " +
REGISTERED + " INTEGER, " +
RELAY + " TEXT, " +
SUPPORTS_SMS + " INTEGER, " +
TIMESTAMP + " INTEGER);";

private static final Object instanceLock = new Object();
private static volatile Directory instance;
Expand All @@ -60,7 +62,7 @@ public static Directory getInstance(Context context) {
private final Context context;

private Directory(Context context) {
this.context = context;
this.context = context;
this.databaseHelper = new DatabaseHelper(context, DATABASE_NAME, null, DATABASE_VERSION);
}

Expand All @@ -69,14 +71,13 @@ public boolean isActiveNumber(String e164number) throws NotInDirectoryException
return false;
}

SQLiteDatabase db = databaseHelper.getReadableDatabase();
String token = getToken(e164number);
Cursor cursor = null;
SQLiteDatabase db = databaseHelper.getReadableDatabase();
Cursor cursor = null;

try {
cursor = db.query(TABLE_NAME,
new String[] {REGISTERED}, TOKEN + " = ?",
new String[] {token}, null, null, null);
new String[]{REGISTERED}, NUMBER + " = ?",
new String[] {e164number}, null, null, null);

if (cursor != null && cursor.moveToFirst()) {
return cursor.getInt(0) == 1;
Expand All @@ -91,12 +92,11 @@ public boolean isActiveNumber(String e164number) throws NotInDirectoryException
}

public String getRelay(String e164number) {
String token = getToken(e164number);
SQLiteDatabase database = databaseHelper.getReadableDatabase();
Cursor cursor = null;

try {
cursor = database.query(TABLE_NAME, null, TOKEN + " = ?", new String[]{token}, null, null, null);
cursor = database.query(TABLE_NAME, null, NUMBER + " = ?", new String[]{e164number}, null, null, null);

if (cursor != null && cursor.moveToFirst()) {
return cursor.getString(cursor.getColumnIndexOrThrow(RELAY));
Expand All @@ -109,27 +109,27 @@ public String getRelay(String e164number) {
}
}

public void setToken(ContactTokenDetails token, boolean active) {
public void setNumber(ContactNumberDetails token, boolean active) {
SQLiteDatabase db = databaseHelper.getWritableDatabase();
ContentValues values = new ContentValues();
values.put(TOKEN, token.getToken());
values.put(NUMBER, token.getNumber());
values.put(RELAY, token.getRelay());
values.put(REGISTERED, active ? 1 : 0);
values.put(SUPPORTS_SMS, token.isSupportsSms() ? 1 : 0);
values.put(TIMESTAMP, System.currentTimeMillis());
db.replace(TABLE_NAME, null, values);
}

public void setTokens(List<ContactTokenDetails> activeTokens, Collection<String> inactiveTokens) {
public void setNumbers(List<ContactNumberDetails> activeTokens, Collection<String> inactiveTokens) {
long timestamp = System.currentTimeMillis();
SQLiteDatabase db = databaseHelper.getWritableDatabase();
db.beginTransaction();

try {
for (ContactTokenDetails token : activeTokens) {
for (ContactNumberDetails token : activeTokens) {
Log.w("Directory", "Adding active token: " + token);
ContentValues values = new ContentValues();
values.put(TOKEN, token.getToken());
values.put(NUMBER, token.getNumber());
values.put(REGISTERED, 1);
values.put(TIMESTAMP, timestamp);
values.put(RELAY, token.getRelay());
Expand All @@ -139,7 +139,7 @@ public void setTokens(List<ContactTokenDetails> activeTokens, Collection<String>

for (String token : inactiveTokens) {
ContentValues values = new ContentValues();
values.put(TOKEN, token);
values.put(NUMBER, token);
values.put(REGISTERED, 0);
values.put(TIMESTAMP, timestamp);
db.replace(TABLE_NAME, null, values);
Expand All @@ -151,21 +151,20 @@ public void setTokens(List<ContactTokenDetails> activeTokens, Collection<String>
}
}

public Set<String> getPushEligibleContactTokens(String localNumber) {
Uri uri = Phone.CONTENT_URI;
Set<String> results = new HashSet<String>();
Cursor cursor = null;
public Set<String> getPushEligibleContactNumbers(String localNumber) {
final Uri uri = Phone.CONTENT_URI;
final Set<String> results = new HashSet<String>();
Cursor cursor = null;

try {
cursor = context.getContentResolver().query(uri, new String[] {Phone.NUMBER}, null, null, null);

while (cursor != null && cursor.moveToNext()) {
String rawNumber = cursor.getString(0);

final String rawNumber = cursor.getString(0);
if (rawNumber != null) {
try {
String e164Number = PhoneNumberFormatter.formatNumber(rawNumber, localNumber);
results.add(getToken(e164Number));
final String e164Number = PhoneNumberFormatter.formatNumber(rawNumber, localNumber);
results.add(e164Number);
} catch (InvalidNumberException e) {
Log.w("Directory", "Invalid number: " + rawNumber);
}
Expand All @@ -175,11 +174,14 @@ public Set<String> getPushEligibleContactTokens(String localNumber) {
if (cursor != null)
cursor.close();

cursor = databaseHelper.getReadableDatabase().query(TABLE_NAME, new String[] {TOKEN},
null, null, null, null, null);
final SQLiteDatabase readableDb = databaseHelper.getReadableDatabase();
if (readableDb != null) {
cursor = readableDb.query(TABLE_NAME, new String[]{NUMBER},
null, null, null, null, null);

while (cursor != null && cursor.moveToNext()) {
results.add(cursor.getString(0));
while (cursor != null && cursor.moveToNext()) {
results.add(cursor.getString(0));
}
}

return results;
Expand All @@ -189,13 +191,20 @@ public Set<String> getPushEligibleContactTokens(String localNumber) {
}
}

public String getToken(String e164number) {
public List<String> getActiveNumbers() {
final List<String> results = new ArrayList<String>();
Cursor cursor = null;
try {
MessageDigest digest = MessageDigest.getInstance("SHA1");
byte[] token = Util.trim(digest.digest(e164number.getBytes()), 10);
return Base64.encodeBytesWithoutPadding(token);
} catch (NoSuchAlgorithmException e) {
throw new AssertionError(e);
cursor = databaseHelper.getReadableDatabase().query(TABLE_NAME, new String[]{NUMBER},
REGISTERED + " = 1", null, null, null, null);

while (cursor != null && cursor.moveToNext()) {
results.add(cursor.getString(0));
}
return results;
} finally {
if (cursor != null)
cursor.close();
}
}

Expand All @@ -215,7 +224,10 @@ public void onCreate(SQLiteDatabase db) {

@Override
public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {

if (oldVersion < INTRODUCED_CHANGE_FROM_TOKEN_TO_E164_NUMBER) {
db.execSQL("DROP TABLE directory;");
onCreate(db);

This comment has been minimized.

Copy link
@moxie0

moxie0 Feb 12, 2014

Contributor

In migration code, you can't reference "existing" code. The migration needs to be a duplicate/snapshot of what exists now, because the code itself might change in the future.

}
}
}

Expand Down
31 changes: 31 additions & 0 deletions library/src/org/whispersystems/textsecure/push/ContactDetails.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
package org.whispersystems.textsecure.push;

import com.google.thoughtcrimegson.Gson;

public abstract class ContactDetails {

private String relay;
private boolean supportsSms;

public ContactDetails() {}

public ContactDetails(String relay) {
this.relay = relay;
}

public String getRelay() {
return relay;
}

public void setRelay(String relay) {
this.relay = relay;
}

public boolean isSupportsSms() {
return supportsSms;
}

public String toString() {
return new Gson().toJson(this);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package org.whispersystems.textsecure.push;

import android.util.Log;

import java.util.ArrayList;
import java.util.List;
import java.util.Map;

public class ContactNumberDetails extends ContactDetails {
private static final String TAG = "ContactNumberDetails";

private String number;

public ContactNumberDetails() { super(); }

public ContactNumberDetails(String number) {
super();
this.number = number;
}

public ContactNumberDetails(String number, String relay) {
super(relay);
this.number = number;
}

public String getNumber() {
return number;
}

public static List<ContactNumberDetails> fromContactTokenDetailsList(List<ContactTokenDetails> contactTokenDetails, final Map<String, String> tokenMap) {
if (contactTokenDetails == null || tokenMap == null) return null;

List<ContactNumberDetails> contactNumberDetails = new ArrayList<ContactNumberDetails>(contactTokenDetails.size());
for (ContactTokenDetails tokenDetails : contactTokenDetails) {
if (tokenMap.containsKey(tokenDetails.getToken()))
contactNumberDetails.add(new ContactNumberDetails(tokenMap.get(tokenDetails.getToken()), tokenDetails.getRelay()));
else
Log.w(TAG, "tokenMap was missing a contact.");
}
return contactNumberDetails;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,40 +2,24 @@

import com.google.thoughtcrimegson.Gson;

public class ContactTokenDetails {
public class ContactTokenDetails extends ContactDetails {

private String token;
private String relay;
private boolean supportsSms;

public ContactTokenDetails() {}
public ContactTokenDetails() { super(); }

public ContactTokenDetails(String token) {
super();
this.token = token;
}

public ContactTokenDetails(String token, String relay) {
super(relay);
this.token = token;
this.relay = relay;
}

public String getToken() {
return token;
}

public String getRelay() {
return relay;
}

public void setRelay(String relay) {
this.relay = relay;
}

public boolean isSupportsSms() {
return supportsSms;
}

public String toString() {
return new Gson().toJson(this);
}
}
33 changes: 33 additions & 0 deletions library/src/org/whispersystems/textsecure/util/DirectoryUtil.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package org.whispersystems.textsecure.util;

import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.Collection;
import java.util.HashMap;
import java.util.Map;

public class DirectoryUtil {

public static String getDirectoryServerToken(String e164number) {
try {
MessageDigest digest = MessageDigest.getInstance("SHA1");
byte[] token = Util.trim(digest.digest(e164number.getBytes()), 10);
return Base64.encodeBytesWithoutPadding(token);
} catch (NoSuchAlgorithmException e) {
throw new AssertionError(e);
}
}

/**
* Get a mapping of directory server tokens to their requested number.
* @param e164numbers
* @return map with token as key, E164 number as value
*/
public static Map<String, String> getDirectoryServerTokenMap(Collection<String> e164numbers) {
final Map<String,String> tokenMap = new HashMap<String,String>(e164numbers.size());
for (String number : e164numbers) {
tokenMap.put(getDirectoryServerToken(number), number);
}
return tokenMap;
}
}

0 comments on commit 9cd5a67

Please sign in to comment.