Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent display of date labels (landscape - portrait switching) #8583

Closed
1 task
pankarlox opened this issue Feb 2, 2019 · 3 comments
Closed
1 task

Inconsistent display of date labels (landscape - portrait switching) #8583

pankarlox opened this issue Feb 2, 2019 · 3 comments

Comments

@pankarlox
Copy link

Bug description

When I click on a conversation with one of my contacts in Signal, the message dates are displayed correctly in the middle of the screen. After switching to landscape mode the dates are displayed on the side of the screen. If I return to portrait mode, the dates 'escape' from the screen.

This issue has already been described here. Unfortunately, nothing has changed since then and the error still exists.

Screenshots

  1. I open conversations. Date is displayed correctly.

signal-attachment2

  1. I turn my phone into landscape mode. The date is in the wrong place.

signal-attachment3

  1. When I return to portrait mode the date 'escapes' from the screen.

signal-attachment

Device info

Device: Samsung Galaxy S9
Android version: 9.0
Signal version: 4.32.8

AND

Device info

Device: Samsung Galaxy A5 2016
Android version: 7.0
Signal version: 4.33.0 (beta)
@billie80 billie80 mentioned this issue Feb 3, 2019
Closed
4 tasks
@C-Higgins
Copy link

Can reproduce this on Galaxy S8, Signal 4.32.8, Android 8.0

@greyson-signal
Copy link
Contributor

Fixed this in the next release branch. Thanks!

greyson-signal added a commit that referenced this issue Feb 15, 2019
@greyson-signal
Fix StickyHeader measuring.
a3768c7 
It didn't re-measure when pulling an item from the cache, screwing stuff
up after a phone rotation. Had a workaround for it for specific screens,
but this fixes the problem at the source.

Fixes #8583
@siccovansas
Copy link
Contributor

Great! Does this also fix #7846 (and the pull request and issue mentioned there)?

ksander314 pushed a commit to ksander314/Signal-Android that referenced this issue Apr 12, 2019
@greyson-signal @ksander314
Fix StickyHeader measuring.
05d1f12 
It didn't re-measure when pulling an item from the cache, screwing stuff
up after a phone rotation. Had a workaround for it for specific screens,
but this fixes the problem at the source.

Fixes signalapp#8583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@siccovansas @C-Higgins @greyson-signal @pankarlox